Skip to content

Lv edits fdar functions review2

Laure Vancau requested to merge lv-edits-fdar-functions-review2 into master

Hello :)

Here are some comments :

  • Try to use epidemiological related things (I added the diabetes dataset from China instead of creating a dataset from nothing in the loops lesson. In the functions lesson, for some examples, I wrote with @LV-EDITS some suggestions for making it more “epi”: can you try to adapt?)
  • Very nice! I like how you split up the chapter into lessons. I agree :)
  • In the loops chapter I did a lot of edits myself in the code
  • In the functions chapter, since I had some of these already, I added some comments with @LV-EDITS for small changes
  • In the functions chapter, for the segments I propose to illustrate (marked by @ILLUTRATE) : do you feel up to doing that or should me/Kene look into it?

Some questions:

  • For the autograders, it wasn’t clear if they were implemented or not: should I already try them out?

Merge request reports

Loading